Re: [PATCH 1/2] crypto: Delete Qualcomm crypto engine driver

From: Kuldeep Singh

Date: Mon May 25 2026 - 02:29:49 EST


> This driver is more than an order of magnitude slower than the CPU for
> both encryption and hashing. See:
>
> https://lore.kernel.org/r/20250704070322.20692-1-ebiggers@xxxxxxxxxx/
> https://lore.kernel.org/r/20250615031807.GA81869@sol/
>
> There are many examples of it having bugs as well, for example see the
> second link above.
>
> That's why it had to be disabled via the cra_priority system. This
> driver was actively making Linux worse.
>
> This isn't particularly unique to drivers/crypto/, of course. This one
> we just have data on, so it's a bit clearer.
>
> I've yet to see any real reason to keep this driver.

https://lore.kernel.org/all/c1697372-54ec-4f57-85d9-ad375ff1a44d@xxxxxxxxxxxxxxxx/
Kindly check my latest reply to the thread. There are numerous usecases
like DRM(Digital rights management) coming up and qce driver is required
for secure content.

> Crypto drivers need to be held to a higher standard than other device
> drivers, as well. The onus is on those who want to keep a particular
> crypto driver to prove that it's worth keeping.
Sure, I'll be working on stabilizing self_tests infra for qce.
Kindly allow sometime to go over failures in crypto selftest and will
submit fix if applicable.
So far, i am observing 2 ciphers failing(xts-aes-qce and ctr-aes-qce )
with CONFIG_CRYPTO_SELFTESTS enabled.

https://lore.kernel.org/r/20250615031807.GA81869@sol/
May I know how to issue reproduce steps because I didn't observe
crypto/ahash.c failure with CONFIG_CRYPTO_SELFTESTS?

--
Regards
Kuldeep