Re: [PATCH] staging: rtl8723bs: remove unnecessary braces and fix indentation in HalPhyRf.c

From: Dan Carpenter

Date: Mon May 25 2026 - 02:50:37 EST


On Sun, May 24, 2026 at 08:52:47PM +0300, Igor Putko wrote:
> Fixed braces around single statement blocks and corrected indentation
> to follow the Linux kernel coding style.

You're going to need to split this into multiple patches.

> @@ -230,14 +229,11 @@ void ODM_TXPowerTrackingCallback_ThermalMeter(struct adapter *Adapter)
> /* else if (pDM_Odm->RFCalibrateInfo.CCK_index < 0) */
> /* pDM_Odm->RFCalibrateInfo.CCK_index = 0; */
> } else {
> - for (p = RF_PATH_A; p < c.RfPathCount; p++)
> - pDM_Odm->RFCalibrateInfo.PowerIndexOffset[p] = 0;
> + for (p = RF_PATH_A; p < c.RfPathCount; p++)
> + pDM_Odm->RFCalibrateInfo.PowerIndexOffset[p] = 0;
> }
>
> /* Print Swing base & current */
> - for (p = RF_PATH_A; p < c.RfPathCount; p++) {
> - }
> -

The comment makes no sense now.

> if (
> (pDM_Odm->RFCalibrateInfo.PowerIndexOffset[RF_PATH_A] != 0 ||
> pDM_Odm->RFCalibrateInfo.PowerIndexOffset[RF_PATH_B] != 0) &&

regards,
dan carpenter