Re: [PATCH] block: partitions: replace __get_free_page() with kmalloc()

From: Mike Rapoport

Date: Mon May 25 2026 - 02:52:31 EST


On Sun, May 24, 2026 at 11:08:31PM -0700, Christoph Hellwig wrote:
> On Wed, May 20, 2026 at 11:15:52AM +0300, Mike Rapoport (Microsoft) wrote:
> > check_partition() allocates a buffer to use as backing buffer for
> > seq_buf.
> >
> > This buffer can be allocated with kmalloc() as there's nothing special
> > about it to go directly to the page allocator.
> >
> > Replace use of __get_free_page() with kmalloc() and free_page() with
> > kfree().
>
> So I heard various vague references that we should replace
> __get_free_page with kmalloc, but nothing definitive. Can you please
> point to a good resource for that?

There was quite recent discussion when I posted patches that change
__get_free_page to return void *:

https://lore.kernel.org/all/20251018093002.3660549-1-rppt@xxxxxxxxxx/

And an old thread when Al posted similar patches:

https://lore.kernel.org/all/CA+55aFwp4iy4rtX2gE2WjBGFL=NxMVnoFeHqYa2j1dYOMMGqxg@xxxxxxxxxxxxxx/T/#u<S-Del>

--
Sincerely yours,
Mike.