Re: [PATCH v3] thermal: core: Add WQ_UNBOUND to alloc_workqueue users

[Marco Crivellari]

On Fri, May 22, 2026 at 6:49 PM Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote:
>
> On Fri, May 15, 2026 at 10:49 AM Marco Crivellari
> <marco.crivellari@xxxxxxxx> wrote:
> >
> > This continues the effort to refactor workqueue APIs, which began with
> > the introduction of new workqueues and a new alloc_workqueue flag in:
> >
> >    commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
> >    commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")
> >
> > The refactoring is going to alter the default behavior of
> > alloc_workqueue() to be unbound by default.
> >
> > With the introduction of the WQ_PERCPU flag (equivalent to !WQ_UNBOUND),
> > any alloc_workqueue() caller that doesn’t explicitly specify WQ_UNBOUND
> > must now use WQ_PERCPU. For more details see the Link tag below.
> >
> > This workqueue has no benefits being per-CPU, so make it unbound adding
> > WQ_UNBOUND, removing also the WQ_POWER_EFFICIENT flag.
> >
> > Link: https://lore.kernel.org/all/20250221112003.1dSuoGyc@xxxxxxxxxxxxx/
> > Suggested-by: Tejun Heo <tj@xxxxxxxxxx>
> > Signed-off-by: Marco Crivellari <marco.crivellari@xxxxxxxx>
> > ---
> > Changes in v3:
> > - remove WQ_POWER_EFFICIENT: the workqueue has more benetifs being unbound,
> >   so just drop this flag and keep only WQ_UNBOUND.
> >
> > Link to v2: https://lore.kernel.org/all/20260514142511.325446-1-marco.crivellari@xxxxxxxx/
> >
> > Changes in v2:
> > - "thermal_events" workqueue has more benefits being unbound, so instead
> >   of WQ_PERCPU, use WQ_UNBOUND.
> >
> > Link to v1: https://lore.kernel.org/all/20260514132901.275477-1-marco.crivellari@xxxxxxxx/
> >
> >  drivers/thermal/thermal_core.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> > index 2f4e2dc46b8f..0b322473deac 100644
> > --- a/drivers/thermal/thermal_core.c
> > +++ b/drivers/thermal/thermal_core.c
> > @@ -1889,7 +1889,7 @@ static int __init thermal_init(void)
> >         if (result)
> >                 goto error;
> >
> > -       thermal_wq = alloc_workqueue("thermal_events", WQ_POWER_EFFICIENT, 0);
> > +       thermal_wq = alloc_workqueue("thermal_events", WQ_UNBOUND, 0);
> >         if (!thermal_wq) {
> >                 result = -ENOMEM;
> >                 goto unregister_netlink;
> > --
>
> Applied as 7.2 material, thanks!

Many thanks!

-- 

Marco Crivellari

SUSE Labs