Re: [PATCH 07/16] arm64: dts: qcom: shikra: Add CPU OPP tables to scale DDR/L3

[Dmitry Baryshkov]

On Mon, May 25, 2026 at 01:19:11AM +0530, Komal Bajaj wrote:
> From: Sayantan Chakraborty <sayantan.chakraborty@xxxxxxxxxxxxxxxx>
> 
> Add OPP tables required to scale DDR and L3 per freq-domain on
> Shikra SoC.
> 
> Signed-off-by: Sayantan Chakraborty <sayantan.chakraborty@xxxxxxxxxxxxxxxx>
> Signed-off-by: Komal Bajaj <komal.bajaj@xxxxxxxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/qcom/shikra.dtsi | 84 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 84 insertions(+)

Does it really make sense to split cpufreq_hw, EPSS and OPP tables into
three separate patches?

> 
> @@ -144,6 +164,70 @@ memory@80000000 {
>  		/* We expect the bootloader to fill in the size */
>  		reg = <0x0 0x80000000 0x0 0x0>;
>  	};
> +	cpu0_opp_table: opp-table-cpu0 {

Missing empty line.

> +		compatible = "operating-points-v2";
> +		opp-shared;
> +
> +		cpu0_opp_768mhz: opp-768000000 {

Drop useless labels.

> +			opp-hz = /bits/ 64 <768000000>;
> +			opp-peak-kBps = <1200000 17817600>;
> +		};

-- 
With best wishes
Dmitry