Re: [PATCH v3] Bluetooth: Add Broadcom channel priority commands
From: Joshua Peisach
Date: Mon May 25 2026 - 10:17:22 EST
On Mon May 25, 2026 at 10:05 AM EDT, Sasha Finkelstein wrote:
On May 25, 2026, at 15:58, Joshua Peisach <jpeisach@xxxxxxxxxx> wrote:
On Mon May 25, 2026 at 8:11 AM EDT, Sasha Finkelstein wrote:
+ cmd.enable = !!enable;
+
Probably a dumb question, but worth asking - what is the purpose of the
"!!"? Wouldn't just passing "enable" be sufficient?
This is a way to enforce that the value is exactly 0 or 1, not 0 or non-zero.
Opposite, actually, this struct is fed to firmware, and it needs to be
Also, currently, cmd.enable seems to just be set and used in the case
of boolean conditions. Would it make sense for the enable field in
brcm_prio_cmd to be a bool or does it not really matter?
specifically a u8.
Got it, thanks!
Reviewed-by: Joshua Peisach <jpeisach@xxxxxxxxxx>