Re: [PATCH v4 13/14] selftests/mm: add userfaultfd RWP tests

From: Kiryl Shutsemau

Date: Mon May 25 2026 - 11:47:03 EST


On Mon, May 25, 2026 at 12:39:03PM +0000, sashiko-bot@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] Hardcoding _UFFDIO_SET_MODE in the unconditionally checked
> expected_ioctls breaks the userfaultfd selftests on older kernels.

Will be fixed in v5 -- dropped _UFFDIO_SET_MODE from expected_ioctls in
test_uffd_api(). The dedicated RWP tests already exercise the ioctl
directly and err if it's not supported, so SET_MODE coverage isn't lost.

> --
> Sashiko AI review · https://sashiko.dev/#/patchset/20260525113737.1942478-1-kas@xxxxxxxxxx?part=13

--
Kiryl Shutsemau / Kirill A. Shutemov