Re: [PATCH] fs: retire stale comment in fget_task_next()

[Jan Kara]

On Fri 22-05-26 16:21:52, Mateusz Guzik wrote:
> The routine originally showed up in e9a53aeb5e0a838f ("file: Implement
> task_lookup_next_fd_rcu"), afterwards it got renamed and started
> entering RCU on its own in 8fd3395ec9051a52 ("get rid of
> ...lookup...fdget_rcu() family").
> 
> Signed-off-by: Mateusz Guzik <mjguzik@xxxxxxxxx>

Right. Thanks for the fixup. Feel free to add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

								Honza

> ---
>  fs/file.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/file.c b/fs/file.c
> index e5c75b22e0c7..628ca07dc4b1 100644
> --- a/fs/file.c
> +++ b/fs/file.c
> @@ -1133,7 +1133,6 @@ struct file *fget_task(struct task_struct *task, unsigned int fd)
>  
>  struct file *fget_task_next(struct task_struct *task, unsigned int *ret_fd)
>  {
> -	/* Must be called with rcu_read_lock held */
>  	struct files_struct *files;
>  	unsigned int fd = *ret_fd;
>  	struct file *file = NULL;
> -- 
> 2.48.1
> 
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR