Re: [PATCH] Fix various spelling mistakes
From: Casey Schaufler
Date: Mon May 25 2026 - 12:38:01 EST
On 5/24/2026 7:15 PM, fffsqian@xxxxxxx wrote:
> From: Qingshuang Fu <fuqingshuang@xxxxxxxxxx>
>
> Fix three spelling errors found in code comments:
>
> - overriden → overridden
> - interated → interacted
> - dont → don't
>
> Signed-off-by: Qingshuang Fu <fuqingshuang@xxxxxxxxxx>
The AppArmor and Smack changes go in through different trees.
You should split this into two patches and submit them to the
appropriate maintainers.
> ---
> security/apparmor/domain.c | 2 +-
> security/apparmor/lsm.c | 2 +-
> security/smack/smackfs.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/security/apparmor/domain.c b/security/apparmor/domain.c
> index f02bf770f638..7e097c40720a 100644
> --- a/security/apparmor/domain.c
> +++ b/security/apparmor/domain.c
> @@ -135,7 +135,7 @@ static int label_compound_match(struct aa_profile *profile,
> struct label_it i;
> struct path_cond cond = { };
>
> - /* find first subcomponent that is in view and going to be interated with */
> + /* find first subcomponent that is in view and going to be interacted with */
> label_for_each(i, label, tp) {
> if (!aa_ns_visible(profile->ns, tp->ns, inview))
> continue;
> diff --git a/security/apparmor/lsm.c b/security/apparmor/lsm.c
> index 3491e9f60194..51a388cfea11 100644
> --- a/security/apparmor/lsm.c
> +++ b/security/apparmor/lsm.c
> @@ -1493,7 +1493,7 @@ static int apparmor_socket_shutdown(struct socket *sock, int how)
> *
> * Note: can not sleep may be called with locks held
> *
> - * dont want protocol specific in __skb_recv_datagram()
> + * don't want protocol specific in __skb_recv_datagram()
> * to deny an incoming connection socket_sock_rcv_skb()
> */
> static int apparmor_socket_sock_rcv_skb(struct sock *sk, struct sk_buff *skb)
> diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c
> index 6e62dcb36f74..2820bd3ee72e 100644
> --- a/security/smack/smackfs.c
> +++ b/security/smack/smackfs.c
> @@ -115,7 +115,7 @@ struct smack_known *smack_syslog_label;
> /*
> * Ptrace current rule
> * SMACK_PTRACE_DEFAULT regular smack ptrace rules (/proc based)
> - * SMACK_PTRACE_EXACT labels must match, but can be overriden with
> + * SMACK_PTRACE_EXACT labels must match, but can be overridden with
> * CAP_SYS_PTRACE
> * SMACK_PTRACE_DRACONIAN labels must match, CAP_SYS_PTRACE has no effect
> */
>
> base-commit: e7ae89a0c97ce2b68b0983cd01eda67cf373517d