Re: [PATCH net-next 2/2] net: dsa: mv88e6xxx: add support for credit based shaper

From: Luke Howard

Date: Tue May 26 2026 - 01:38:43 EST


Hi Cedric,

One followup:

I could be missing some patches from you due to netdev volume but, do you have a separate patch set for hardware offloaded MQPRIO?

Your example uses hw 0 (software MQPRIO) which doesn’t program the switch’s FPri/QPri mapping. For switches excepting the 6390 family, this mapping is per-chip, which means one needs to validate it is identical for every port on which CBS can be enabled.

Cheers,
Luke

> On 26 May 2026, at 10:32, Luke Howard <lukeh@xxxxxxxx> wrote:
>
> Hi Cedric,
>
> We sent RFC patches for mv88e6xxx support for both MQPRIO [1] and CBS [2] last year. (We have since made a few small changes which can be found in our working tree at [3].)
>
> We have been using these patches successfully for the past year with our SRP stack [4] on a custom board with a 88E6352. The CBS and MQPRIO patches remain unsubmitted because we also needed extend the Netlink API and software bridge with a flag indicating a FDB/MDB entry is managed by SRP.
>
> I would be happy to work together to harmonise our patches to avoid duplicated effort.
>
> Cheers,
> Luke
>
> [1] https://lists.openwall.net/netdev/2025/09/27/34
> [2] https://lists.openwall.net/netdev/2025/09/27/26
> [3] https://github.com/PADL/linux/tree/rpi-6.18.y-xebros-rmu
> [4] https://github.com/PADL/OpenSRP