Re: [PATCH 1/2] dt-bindings: regulator: mps,mp8899: Add binding for MP8899 PMIC
From: Vignesh Viswanathan
Date: Tue May 26 2026 - 03:40:21 EST
On 5/20/2026 3:58 PM, Krzysztof Kozlowski wrote:
> On Tue, May 19, 2026 at 11:51:05PM +0530, Vignesh Viswanathan wrote:
>> Add devicetree binding documentation for the Monolithic Power Systems
>> MP8899 PMIC, which provides four synchronous buck converters controlled
>> over I2C.
>
> Ah, and one more, standard comment (so you could have avoided that
> easily):
>
> Drop second/last, redundant "binding for". The
> "dt-bindings" prefix is already stating that these are bindings.
> See also:
> https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
Sure, will drop the redundant text.
Thanks,
Vignesh
>
> Best regards,
> Krzysztof
>