Re: [PATCH 02/17] tools/arch/x86/pmtctl: Add libpmtctl shared type enumerations

[Ilpo Järvinen]

On Mon, 25 May 2026, David E. Box wrote:

> Add pmtctl_types.h to centralize shared libpmtctl type definitions used
> across both the public and internal library interfaces.
> 
> This provides a common definition point for core library-facing types,
> including device backend classification and logging verbosity levels,
> avoiding duplication across API boundaries.
> 
> Assisted-by: GitHub-Copilot:claude-sonnet-4.6
> Signed-off-by: David E. Box <david.e.box@xxxxxxxxxxxxxxx>
> ---
>  tools/arch/x86/pmtctl/include/lib/pmtctl_types.h | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>  create mode 100644 tools/arch/x86/pmtctl/include/lib/pmtctl_types.h
> 
> diff --git a/tools/arch/x86/pmtctl/include/lib/pmtctl_types.h b/tools/arch/x86/pmtctl/include/lib/pmtctl_types.h
> new file mode 100644
> index 000000000000..8e3bf5a173c4
> --- /dev/null
> +++ b/tools/arch/x86/pmtctl/include/lib/pmtctl_types.h
> @@ -0,0 +1,16 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +#ifndef PMTCTL_TYPES_H
> +#define PMTCTL_TYPES_H
> +
> +enum pmt_device_type {
> +	PMT_DEVICE_TELEM

Missing comma.

> +};
> +
> +enum pmtctl_log_level {
> +	PMTCTL_LOG_ERROR = 0,
> +	PMTCTL_LOG_WARN,
> +	PMTCTL_LOG_INFO,
> +	PMTCTL_LOG_DEBUG,
> +};
> +
> +#endif
> 

-- 
 i.