Re: [PATCH] regulator: mt6363: select CONFIG_IRQ_DOMAIN

[AngeloGioacchino Del Regno]

On 5/26/26 12:19, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> When build-testing this driver without CONFIG_IRQ_DOMAIN causes
> a compile-time error:
>
> drivers/regulator/mt6363-regulator.c: In function 'mt6363_regulator_probe':
> drivers/regulator/mt6363-regulator.c:884:18: error: implicit declaration of function 'irq_find_host' [-Wimplicit-function-declaration]
>    884 |         domain = irq_find_host(interrupt_parent);
>        |                  ^~~~~~~~~~~~~
> drivers/regulator/mt6363-regulator.c:884:16: error: assignment to 'struct irq_domain *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
>    884 |         domain = irq_find_host(interrupt_parent);
>        |                ^
> drivers/regulator/mt6363-regulator.c:896:30: error: implicit declaration of function 'irq_create_fwspec_mapping'; did you mean 'irq_create_of_mapping'? [-Wimplicit-function-declaration]
>    896 |                 info->virq = irq_create_fwspec_mapping(&fwspec);
>        |                              ^~~~~~~~~~~~~~~~~~~~~~~~~
>        |                              irq_create_of_mapping
>
> This is rather hard to trigger because so many other drivers
> enable IRQ_DOMAIN already, but I ran into this on an s390
> randconfig build.
>
> Ensure this is always enabled using a Kconfig 'select IRQ_DOMAIN'
> entry, as we do for all other users of this.
>
> Fixes: 3c36965df808 ("regulator: Add support for MediaTek MT6363 SPMI PMIC Regulators")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>