Re: [PATCH v3 1/4] drm/scdc-helper: Don't use ssize_t return type for scdc_read/write

From: Luca Ceresoli

Date: Tue May 26 2026 - 07:41:27 EST


On Tue, 26 May 2026 12:19:57 +0200, Nicolas Frattaroli <nicolas.frattaroli@xxxxxxxxxxxxx> wrote:
> drm_scdc_read and drm_scdc_write, both of which are only used within
> drm_scdc_helper (although exported), use a ssize_t as their return type.
>
> This would make sense if they returned the number of bytes read/written
> on success, and negative errno otherwise. However, they return 0 on
> success.
>
> [...]

Reviewed-by: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx>

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com