回复: [PATCH v1 1/3] dt-bindings: i2c: snps,dwc-i2c: Add StarFive JHB100 bindings

[Lianfeng Ouyang]

Best Regards,
Lianfeng Ouyang

> -----邮件原件-----
> 发件人: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> 发送时间: 2026年5月22日 4:34
> 收件人: Lianfeng Ouyang <lianfeng.ouyang@xxxxxxxxxxxxxxxx>; Andi Shyti
> <andi.shyti@xxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzk+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; Mika
> Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>; Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx>; Jan Dabros <jsd@xxxxxxxxxxxx>
> 抄送: linux-i2c@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx
> 主题: Re: [PATCH v1 1/3] dt-bindings: i2c: snps,dwc-i2c: Add StarFive JHB100
> bindings
> 
> On 21/05/2026 05:43, lianfeng.ouyang wrote:
> > +
> > +  starfive,mctp-i2c-ms:
> > +    description: |
> > +      The property should contain reference to the master node associated
> with the slave.
> 
> It's redundant to say that property is "the property ...". Just SAY
> describe that.
> 
> Also, wrap according to Linux coding style.

Okay, I will optimize this type of description in the next version

> 
> > +      This value is only used in slave mode, especially for MCTP application.
> > +
> > +  dwc-i2c-tx-fifo-depth:
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    description: |
> > +      The property describes the tx fifo depth.
> > +    default: 8
> > +
> > +  dwc-i2c-rx-fifo-depth:
> Wrong name. Generic properties DO NOT use "dwc" name. Please use
> existing standard properties from dtschema, other common schemas or just
> look around.
> 
> Do not invent your own stuff and unfortunately half of this binding is
> such invention - done completely different than everything else. That's
> a sign of downstream code and we really do not like such code.

I couldn't find a property similar to fifty depth in the other I2C driver. I plan to 
use Starfive,I2C-tx-fifo-depth in the next version

> 
> A nit, subject: drop second/last, redundant "bindings". The
> "dt-bindings" prefix is already stating that these are bindings.
> See also:
> https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bin
> dings/submitting-patches.rst#L18
> 
> Please read carefully writing-bindings document and submitting-patches
> in DT dir.

Thank you for the recommendation. I will carefully read this document

> 
> Best regards,
> Krzysztof