Re: [PATCH v9 02/11] dt-bindings: iio: adc: hx711: add VSUP supply property

[Jonathan Cameron]

On Sun, 24 May 2026 08:12:13 +0530
Piyush Patle <piyushpatle228@xxxxxxxxx> wrote:

> On Wed, May 20, 2026 at 3:39 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
> >
> > On Tue, 19 May 2026 03:32:18 +0530
> > Piyush Patle <piyushpatle228@xxxxxxxxx> wrote:
> >  
> > > Document the optional VSUP supply used by the HX711 on-chip regulator.
> > >
> > > Signed-off-by: Piyush Patle <piyushpatle228@xxxxxxxxx>
> > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
> > > Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>  
> > See my reply to v8 around dvdd needing (I think) to be in this patch
> > for the hx711 not later in the series.
> >  
> > > ---
> > > No change from v8. Already applied to iio.git testing branch.
> > >  Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml b/Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml
> > > index 1ea60dff98d5..a8eaa1f18de5 100644
> > > --- a/Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml
> > > +++ b/Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml
> > > @@ -33,6 +33,10 @@ properties:
> > >      description:
> > >        Analog supply voltage (AVDD).
> > >
> > > +  vsup-supply:
> > > +    description:
> > > +      Supply voltage for the on-chip regulator (VSUP).
> > > +
> > >    clock-frequency:
> > >      description:
> > >        Controls the SCK bit-bang timing. The value is used to derive the  
> >  
> Acknowledged, and sorry for not acting on this in v9. In v10,
> I will add dvdd-supply in patch 02/11 alongside vsup-supply with a
> description that makes clear it is the digital input supply of the
> HX711 (and not just a bypass capacitor point).
> 
> The description will read something like:
> 
>    dvdd-supply:
>      description:
>        Digital supply voltage (DVDD). On the HX711 DVDD is a board-
>        supplied digital rail, distinct from VSUP; they may be tied to
>        the same supply or driven separately.

I'm not seeing a reason for this extra text.  The standard nature of a supply
being present covers all this. Otherwise we would not have it!

Fine to have a bit of this in the changelog for the series + maybe
briefly touch on it in the patch description.

Thanks,

Jonathan