Re: [PATCH net-next 2/2] net: dsa: mv88e6xxx: add support for credit based shaper

From: Luke Howard

Date: Tue May 26 2026 - 08:37:33 EST



> I've looked at these patches before starting. I quickly ran into the limitation the driver only supports 3 traffic classes. I want to be able to send traffic from the cpu to other queues too.

Yes, fair point, a compromise because our goal was to support offloaded switching of SRP-managed AVB streams. Only the 6390 family of Marvell switch chips support CBS with more than two queues (the third being legacy).

> I'm trying to upstream changes one topic at a time. Eg. this CBS patch is only for configuring the shaper. How traffic ends up in a certain queue is not relevant for this patch.

Right, we did it in the reverse order (MQPRIO then CBS, as separate commits but in the same patch series).

Now I have a solution for flagging SRP-managed MDB entries, I should be in a position to resubmit the patch set after regression testing. One thing have incorporated from your patch is dynamically enabling strict priority scheduling (thank you).