Re: [PATCH v2 5/6] PCI/PM: Use pci_power_manageable() in pci_pm_poweroff_noirq()

[Rafael J. Wysocki]

On Mon, Apr 27, 2026 at 10:50 PM Mario Limonciello (AMD)
<superm1@xxxxxxxxxx> wrote:
>
> Devices with no subordinate should be put into D3 during hibernate, but
> devices that have bridge_d3 set should also be put to sleep during
> hibernate.

Why should they?

> Adjust the check in pci_pm_poweroff_noirq() to use
> pci_power_manageable() to cover those as well.

Please say what actual problem is addressed by this change.

> Tested-by: Eric Naim <dnaim@xxxxxxxxxxx>
> Signed-off-by: Mario Limonciello (AMD) <superm1@xxxxxxxxxx>
> ---
>  drivers/pci/pci-driver.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c
> index 793af4af2971b..3c82d818ee15b 100644
> --- a/drivers/pci/pci-driver.c
> +++ b/drivers/pci/pci-driver.c
> @@ -1254,7 +1254,7 @@ static int pci_pm_poweroff_noirq(struct device *dev)
>                         return error;
>         }
>
> -       if (!pci_dev->state_saved && !pci_has_subordinate(pci_dev))
> +       if (!pci_dev->state_saved && pci_power_manageable(pci_dev))
>                 pci_prepare_to_sleep(pci_dev);
>
>         /*
> --
> 2.53.0
>