Re: [PATCH] firmware: stratix10-rsu: Fix NULL deref on rsu_send_msg() timeout in probe

From: Dinh Nguyen

Date: Tue May 26 2026 - 10:36:55 EST




On 5/21/26 11:33, Markus Elfring wrote:

Apply the same cleanup pattern to the remaining failure paths: remove the
async client, free the channel, and return early so no further messages are
queued on a channel whose scl has been cleared.


How do you think about to avoid a bit of duplicate source code
in the implementation of the function “stratix10_rsu_probe”?
https://elixir.bootlin.com/linux/v7.1-rc4/source/drivers/firmware/stratix10-rsu.c#L715-L807

Excellent suggestion.

Thanks,
Dinh