Re: [PATCH] MIPS: DEC: Remove IRQF_ONESHOT reference for IOASIC DMA error IRQs
From: Thomas Bogendoerfer
Date: Tue May 26 2026 - 11:18:09 EST
On Wed, May 06, 2026 at 12:15:21PM +0100, Maciej W. Rozycki wrote:
> There is no need for IOASIC DMA error interrupts to use the IRQF_ONESHOT
> flag, because while they do need to have the source cleared only at the
> conclusion of handling, the action handler supplied is either run in the
> hardirq context with interrupts disabled at the CPU level or, where IRQ
> threading has been forced, the primary handler has the IRQF_ONESHOT flag
> implicitly added and therefore the original action handler, now run as
> the thread handler and with interrupts enabled in the CPU, is executed
> with the originating interrupt line masked. Therefore no interrupt will
> retrigger regardless until the original request has been handled.
>
> Link: https://lore.kernel.org/r/20260127135334.qUEaYP9G@xxxxxxxxxxxxx/
> Reported-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> Signed-off-by: Maciej W. Rozycki <macro@xxxxxxxxxxx>
> ---
> arch/mips/dec/ioasic-irq.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
applied to mips-next
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]