Re: [PATCH v2] staging: sm750fb: fix CamelCase variables name in sm750

From: Greg KH

Date: Tue May 26 2026 - 12:23:17 EST


On Tue, May 26, 2026 at 10:16:31AM -0300, Emmanuel Arias wrote:
> Replace CamelCase variable name with snake_case:
> - pvReg -> pv_reg

Why are you keeping the "pv_"? What does that mean?

> - setAllEngOff -> set_all_eng_off
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>

The test robot told you to make this change?

> Closes: https://lore.kernel.org/oe-kbuild-all/202605171049.KbaBnrJV-lkp@xxxxxxxxx/
> Signed-off-by: Emmanuel Arias <eamanu@xxxxxxxxxx>
> ---
> drivers/staging/sm750fb/sm750.c | 6 +++---
> drivers/staging/sm750fb/sm750.h | 4 ++--
> drivers/staging/sm750fb/sm750_hw.c | 12 ++++++------
> 3 files changed, 11 insertions(+), 11 deletions(-)

What changed from v1?

thanks,

greg k-h