Re: [PATCH] media: atomisp: use __func__ in debug messages in binary.c
From: Greg KH
Date: Tue May 26 2026 - 12:53:47 EST
On Tue, May 26, 2026 at 10:47:50AM +0000, Jeongin Yeo wrote:
> Replace hardcoded function name strings with __func__ macro in
> dev_dbg() calls within ia_css_binary_find() as recommended by
> kernel coding style.
>
> No functional changes.
>
> Signed-off-by: Jeongin Yeo <jeongin.yeo@xxxxxxxxxxxx>
> ---
> .../atomisp/pci/runtime/binary/src/binary.c | 127 ++++++++++--------
> 1 file changed, 68 insertions(+), 59 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c b/drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c
> index e9016d7775dc3..2355fdf357fcd 100644
> --- a/drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c
> +++ b/drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c
> @@ -925,8 +925,8 @@ int ia_css_binary_find(struct ia_css_binary_descr *descr, struct ia_css_binary *
> /* MW: used after an error check, may accept NULL, but doubtful */
> assert(binary);
>
> - dev_dbg(atomisp_dev, "ia_css_binary_find() enter: descr=%p, (mode=%d), binary=%p\n",
> - descr, descr->mode, binary);
> + dev_dbg(atomisp_dev, "%s() enter: descr=%p, (mode=%d), binary=%p\n",
> + __func__, descr, descr->mode, binary);
dev_dbg() already has __func__ in the output, why is it needed again?
thanks,
greg k-h