Re: [PATCH v3 2/4] iio: light: add support for veml6031x00 ALS series

[Jonathan Cameron]

On Tue, 26 May 2026 18:59:33 +0100
Jonathan Cameron <jic23@xxxxxxxxxx> wrote:

> On Sun, 24 May 2026 23:53:56 +0200
> Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx> wrote:
> 
> > These sensors provide two light channels (ALS and IR), I2C communication
> > and a multiplexed interrupt line to signal data ready and configurable
> > threshold alarms.
> > 
> > This first implementation provides basic functionality (measurement
> > configuration, raw reads and ID validation) and defines the different
> > register regions in preparation for extended features in the subsequent
> > patches of the series.
> > 
> > Signed-off-by: Javier Carrasco <javier.carrasco.cruz@xxxxxxxxx>  
> 
> A few things inline.  Biggest one is that device driver specific state needs
> local well documented locking. Here the whole complex gain handling means there
> are a bunch of register field where the accesses to each set of them need
> to appear atomic.
The sashiko comment on underflowing pm counters also looks plausible
so check that as well.