RE: [Intel-wired-lan] [PATCH v2] i40e: Fix i40e_debug() to use struct i40e_hw argument
From: Nowlin, Alexander
Date: Tue May 26 2026 - 18:15:49 EST
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of Mohamed Khalfella
> Sent: Wednesday, May 6, 2026 3:41 PM
> To: Nguyen, Anthony L <anthony.l.nguyen@xxxxxxxxx>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@xxxxxxxxx>; David S . Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet
> <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>
> Cc: Mohamed Khalfella <mkhalfella@xxxxxxxxxxxxxxx>; Loktionov, Aleksandr
> <aleksandr.loktionov@xxxxxxxxx>; Paul Menzel <pmenzel@xxxxxxxxxxxxx>; Keller, Jacob E
> <jacob.e.keller@xxxxxxxxx>; intel-wired-lan@xxxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: [Intel-wired-lan] [PATCH v2] i40e: Fix i40e_debug() to use struct i40e_hw argument
>
> i40e_debug() macro takes struct i40e_hw *h as first argument. But the macro body uses hw instead of
> h. This has been working so far because hw happens to be the name of the variable in the context
> where the macro is expanded. Fix the macro to use the passed argument.
>
> Fixes: 5dfd37c37a44 ("i40e: Split i40e_osdep.h")
> Signed-off-by: Mohamed Khalfella <mkhalfella@xxxxxxxxxxxxxxx>
> Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@xxxxxxxxx>
> Reviewed-by: Paul Menzel <pmenzel@xxxxxxxxxxxxx>
> ---
> drivers/net/ethernet/intel/i40e/i40e_debug.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Tested-by: Alexander Nowlin <alexander.nowlin@xxxxxxxxx>