RE: [PATCH net-next v2 2/2] net: lan743x: add support for RMII interface

[Thangaraj.S]

Hi Andrew,
Thanks for the comments.

> -----Original Message-----
> From: Andrew Lunn <andrew@xxxxxxx>
> Sent: Tuesday, May 26, 2026 10:20 PM
> To: Thangaraj Samynathan - I53494 <Thangaraj.S@xxxxxxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx; andrew+netdev@xxxxxxx;
> davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx;
> pabeni@xxxxxxxxxx; Bryan Whitehead - C21958
> <Bryan.Whitehead@xxxxxxxxxxxxx>; UNGLinuxDriver
> <UNGLinuxDriver@xxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH net-next v2 2/2] net: lan743x: add support for RMII
> interface
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know
> the content is safe
> 
> On Tue, May 26, 2026 at 09:10:54PM +0530, Thangaraj Samynathan wrote:
> > Enable RMII interface in the lan743x driver for PHY and MAC
> > configuration.
> >
> > - Select RMII interface in lan743x_phy_interface_select().
> > - Update phylink supported_interfaces and MAC capabilities.
> > - Enable RMII via RMII_CTL in lan743x_hardware_init().
> > - Define RMII_CTL register and enable bit in lan743x_main.h.
> 
> > +     case PHY_INTERFACE_MODE_RMII:
> > +             __set_bit(PHY_INTERFACE_MODE_RMII,
> > +                       adapter->phylink_config.supported_interfaces);
> > +             adapter->phylink_config.lpi_capabilities = 0;
> 
> So EEE is not supporting with RMII? This is not mentioned in the commit
> message.
> 
> Humm, is this an 802.3 limitation, or a limitation of this hardware?
> If this is 802.3, then this should be in phylink, not drivers.
> 
[Thangaraj Samynathan] No. This is the limitation of hardware. Will update
The commit message in next revision. 
>         Andrew