Re: [PATCH] freevxfs: don't BUG() on duplicate OLT entries

From: Christoph Hellwig

Date: Wed May 27 2026 - 02:26:26 EST


On Tue, May 26, 2026 at 11:49:47AM -0700, Farhad Alemi wrote:
> Hi Christoph,
>
> Thanks for the review. Before sending v2, I tested WARN_ON_ONCE against the
> original reproducer, and on a panic_on_warn=y kernel it still panics (the
> WARN fires and panic_on_warn promotes it).
> Would pr_warn_once() work instead, to keep the diagnostic without the
> panic_on_warn coupling?

That's fine. People who set panic_on_warn=y for anyting but debug
kernels deserve this.

> Happy to respin either way — just thought I'd check before doing so.

Sure, it's always good to ask!