Re: [PATCH 4/6] ASoC: qcom: audioreach: Add support for shared memory push/pull modules

[Mark Brown]

On Tue, May 19, 2026 at 01:15:25PM +0000, Srinivas Kandagatla wrote:
> Push-pull graphs use MODULE_ID_SH_MEM_PULL_MODE for playback and
> MODULE_ID_SH_MEM_PUSH_MODE for capture instead of the legacy WR/RD shared
> memory endpoints. Detect these modules when opening the graph, cache their
> instance ID in graph->shm_iid, and use them for media format setup.

This doesn't build:

/build/stage/linux/sound/soc/qcom/qdsp6/q6apm.c: In function ‘__q6apm_map_memory
_fixed_region’:
/build/stage/linux/sound/soc/qcom/qdsp6/q6apm.c:218:42: error: ‘APM_MMAP_TOKEN_M
AP_TYPE_POS_BUF’ undeclared (first use in this function)
  218 |         uint32_t pos_mask = is_pos_buf ? APM_MMAP_TOKEN_MAP_TYPE_POS_BUF
 : 0;
      |                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/build/stage/linux/sound/soc/qcom/qdsp6/q6apm.c:218:42: note: each undeclared id
entifier is reported only once for each function it appears in
/build/stage/linux/sound/soc/qcom/qdsp6/q6apm.c: In function ‘apm_callback’:
/build/stage/linux/sound/soc/qcom/qdsp6/q6apm.c:943:41: error: ‘APM_MMAP_TOKEN_G
ID_MASK’ undeclared (first use in this function); did you mean ‘APM_WRITE_TOKEN_
LEN_MASK’?
  943 |                 graph_id = hdr->token & APM_MMAP_TOKEN_GID_MASK;
      |                                         ^~~~~~~~~~~~~~~~~~~~~~~
      |                                         APM_WRITE_TOKEN_LEN_MASK
/build/stage/linux/sound/soc/qcom/qdsp6/q6apm.c:944:43: error: ‘APM_MMAP_TOKEN_MAP_TYPE_POS_BUF’ undeclared (first use in this function)
  944 |                 is_pos_buf = hdr->token & APM_MMAP_TOKEN_MAP_TYPE_POS_BUF;
      |                                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

It's defined later in the series.

Attachment: signature.asc
Description: PGP signature