Re: [PATCH net-next 5/6] net: dsa: mv88e6xxx: CBS support

[Luke Howard]

> Why is the avb_mode set from the cbs setter?
> avb_mode is an ingress setting that controls if frames are classified as
> AVB frames. Cbs configures shaping on egress.
> Eg. if an AVB stream is received on port 1 and is forwarded by the switch to
> port 2. AvbMode needs to be set on port 1 and cbs is configured on port 2.

Sounds like a bug which might explain why enhanced/secure mode didn’t work when I last tested it :)

I think it might make sense to have CBS just configure the shaper/strict priority (i.e. as your patch does), and then only enable AVB mode if the shaper TC has a MQPRIO parent (retaining the mapping of TCs to AVB classes).