Re: [PATCH v3 2/3] media: i2c: imx471: Add Sony IMX471 image sensor driver

[Sakari Ailus]

Hi Kate,

On Wed, May 27, 2026 at 02:14:24PM +0800, Kate Hsuan wrote:
> > > +struct imx471 {
> > > +     struct v4l2_subdev sd;
> > > +     struct media_pad pad;
> > > +
> > > +     struct v4l2_ctrl_handler ctrl_handler;
> > > +     /* V4L2 Controls */
> > > +     struct v4l2_ctrl *link_freq;
> > > +     struct v4l2_ctrl *pixel_rate;
> > > +     struct v4l2_ctrl *vblank;
> > > +     struct v4l2_ctrl *hblank;
> > > +     struct v4l2_ctrl *vflip;
> > > +     struct v4l2_ctrl *hflip;
> > > +     struct v4l2_ctrl *exposure;
> >
> > Do you need all these? At least link_freq remains effectively unused.
> I'll tweak these ctrl based on
> https://libcamera.org/sensor_driver_requirements.html.

I rather meant that you're assigning all of these fields but then not using
them. You could thus remove the fields and the assignments. But I can't say
which ones, apart from link_freq.

-- 
Kind regards,

Sakari Ailus