Re: [PATCH net-next v2 1/2] net: lan743x: add RMII strap status detection for PCI11x1x

[Andrew Lunn]

> > EXTERNAL EMAIL: Do not click links or open attachments unless you know
> > the content is safe
> > 
> > > +     if (!adapter->is_sgmii_en && strap & STRAP_READ_USE_RMII_EN_) {
> > > +             if (strap & STRAP_READ_RMII_EN_)
> > > +                     adapter->is_rmii_en = true;
> > > +     }
> > 
> > What does it mean when both SGMII and RMII is strapped? What if neither
> > is strapped?
> [Thangaraj Samynathan] When both are enabled, Interface will SGMII. When
> Both are disabled interface will be RGMII.

So both enabled is not an error, we don't need to give a warning that
the board design is broken?

> > >       netif_dbg(adapter, drv, adapter->netdev,
> > >                 "SGMII I/F %sable\n", adapter->is_sgmii_en ? "En" :
> > > "Dis");
> > 
> > Since there is a netif_dbg() for sgmii, maybe add one for rmii, so the code is
> > somewhat symmetrical?
> [Thangaraj Samynathan] Sure. Will add it in the next revision. 

and maybe also add RGMII. Looking at this code, it is not obvious that
RGMII can be indicated by strapping.

	Andrew