Re: [PATCH] memory: tegra: add multi-socket support to the memory interconnect

[Krzysztof Kozlowski]

On 21/05/2026 16:05, Sumit Gupta wrote:
> -		err = icc_link_create(node, TEGRA_ICC_MC);
> +		err = tegra_mc_icc_link_create(node, node_id, TEGRA_ICC_MC);
>  		if (err)
>  			goto remove_nodes;
>  
> @@ -957,7 +969,13 @@ static int tegra_mc_probe(struct platform_device *pdev)
>  	if (IS_ERR(mc->regs))
>  		return PTR_ERR(mc->regs);
>  
> -	mc->debugfs.root = debugfs_create_dir("mc", NULL);
> +	if (!mc_debugfs_root)

That's a probe path and you created a singletone. Looks like preventing
async probing for no real reason.

I am very against singletons and debugfs does not look like justified
exception.

> +		mc_debugfs_root = debugfs_create_dir("mc", NULL);
> +
> +	if (dev_to_node(mc->dev) == NUMA_NO_NODE)
> +		mc->debugfs.root = mc_debugfs_root;
> +	else
> +		mc->debugfs.root = debugfs_create_dir(dev_name(mc->dev), mc_debugfs_root);
>  


Best regards,
Krzysztof