Re: [PATCH v2 2/3] i2c: designware: Export symbols and add __weak for Starfive I2C driver
From: Krzysztof Kozlowski
Date: Wed May 27 2026 - 09:17:00 EST
On 27/05/2026 10:50, lianfeng.ouyang wrote:
> dev->dev = device;
> dev->irq = irq;
> dev->flags = flags;
> @@ -255,6 +259,8 @@ static const struct of_device_id dw_i2c_of_match[] = {
> { .compatible = "mobileye,eyeq6lplus-i2c" },
> { .compatible = "mscc,ocelot-i2c" },
> { .compatible = "snps,designware-i2c" },
> + { .compatible = "starfive,jhb100-i2c-master" },
> + { .compatible = "starfive,jhb100-i2c-slave" },
So both devices are the same... Or you miss proper entry in ID table.
Don't sprinkle compatibles around the code - ID table match data is for
variant customization.
Best regards,
Krzysztof