Re: [PATCH v3 3/5] arm64: dts: qcom: Add Shikra CQ2390M SoM platform

[Komal Bajaj]

On 5/25/2026 6:46 PM, Konrad Dybcio wrote:
> On 5/22/26 8:02 PM, Komal Bajaj wrote:
> > Add device tree include for the CQ2390M variant of the Shikra
> > System-on-Module, a compact compute module integrating the Shikra SoC
> > and PMIC for IoT applications, designed to mount on carrier boards.
> >
> >    - shikra-cqm-som.dtsi: Retail SoM with modem (PM4125 and PM8005 PMIC)
> >
> > The DTSI includes the common shikra.dtsi, adds PM4125 and PM8005 PMIC
> > regulator definitions specific to this variant.
> >
> > Co-developed-by: Rakesh Kota <rakesh.kota@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Rakesh Kota <rakesh.kota@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Komal Bajaj <komal.bajaj@xxxxxxxxxxxxxxxx>
> > ---
> [...]
>
> > +/ {
> > +	gpio-key {
> This is usually 'gpio-keys', reglardless of the amount

ACK

> > +		compatible = "gpio-keys";
> > +		label = "gpio-keys";
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&vol_up_n>;
> property-n
> property-names
>
> in this order, please

Yes, i will correct this.

> [...]
>
> > +&pm4125_resin {
> > +	linux,code = <KEY_VOLUMEDOWN>;
> > +	status = "okay";
> A \n before 'status' is customary

ACK

> > +};
> > +
> > +&pm8005_regulators {
> > +	status = "disabled";
> > +};
> ?

Already there's an ongoing discussion over the thread [1].
PM8005 regulators are controlled by rpmpd so it's not expected to be 
enabled here.

[1]: 
https://lore.kernel.org/all/20260525093453.edmqryggp5kcqxxy@xxxxxxxxxxxxxxxxxxxxxxxxxxxx/

> (also double \n below)

Will remove it.

Thanks
Komal

> Konrad