Re: [PATCH v5 21/24] gpu: nova-core: separate driver type from driver data

From: Gary Guo

Date: Wed May 27 2026 - 09:43:03 EST


On Mon May 25, 2026 at 9:21 PM BST, Danilo Krummrich wrote:
> Introduce NovaCoreDriver as the driver type implementing pci::Driver,
> keeping NovaCore as the per-device data type. This prepares for making
> NovaCore lifetime-parameterized once auxiliary::Registration requires a
> lifetime for the binding scope.
>
> Reviewed-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Reviewed-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
> Reviewed-by: Eliot Courtney <ecourtney@xxxxxxxxxx>
> Signed-off-by: Danilo Krummrich <dakr@xxxxxxxxxx>

Reviewed-by: Gary Guo <gary@xxxxxxxxxxx>

> ---
> drivers/gpu/nova-core/driver.rs | 14 ++++++++------
> drivers/gpu/nova-core/nova_core.rs | 2 +-
> 2 files changed, 9 insertions(+), 7 deletions(-)