Re: [PATCH v3] iio: gyro: mpu3050: fix missing iio_trigger_unregister and irq cleanup

[Linus Walleij]

On Thu, May 21, 2026 at 1:47 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote:

> This is interesting. I wonder why we paper over the failed trigger
> registration.   Generally that's an error case that should
> result in the driver not loading.

Right, given that we have an irq, it should either probe
the trigger or fail.

> The mix of devm and non devm in iio_trigger_register() is also
> nasty.

OK that's maybe due to the initial overbelief in devm_*
garbage collection. It should be cleaned up to whatever
is the best.

Yours,
Linus Walleij