Re: [PATCH] s390/string: Remove strlcat() implementation

From: Heiko Carstens

Date: Wed May 27 2026 - 10:17:20 EST


On Wed, May 27, 2026 at 02:03:58PM +0100, David Laight wrote:
> On Fri, 22 May 2026 16:31:11 +0200
> Heiko Carstens <hca@xxxxxxxxxxxxx> wrote:
>
> > strlcat() shouldn't be used anymore (see fortify-string.h), and will be
> > deprecated / removed sooner or later [1].
> >
> ....
> > #define __HAVE_ARCH_STRCAT /* inline & arch function */
> ...
> > #define __HAVE_ARCH_STRNCAT /* arch function */
>
> Those two should probably have gone first ...

Yes, except that we need strcat() for the boot code - there we cannot use the
generic variant. Of course it would be possible to copy the existing strcat()
implementation to the boot code, rename it to e.g. strconcatenate(), and
strcat()/strncat() would be gone, at least grep wise :)