Re: [PATCH] err.h: use __always_inline on all error pointer helpers

[Alexander Lobakin]

From: Arnd Bergmann <arnd@xxxxxxxx>
Date: Wed, 27 May 2026 16:25:41 +0200

> On Wed, May 27, 2026, at 16:06, Alexander Lobakin wrote:
>> From: Arnd Bergmann <arnd@xxxxxxxx>
>> Date: Tue, 26 May 2026 23:03:50 +0200
>>>
>>> Without CONFIG_PROFILE_ANNOTATED_BRANCHES, the changes are
>>> very small, with around 100 functions growing or shrinking
>>> by a few bytes.
>>>
>>> I don't think we care much about the size increase when that
>>> option is enabled, but I do wonder what behavior makes more
>>
>> Yup, and even without this option, __always_inline is better here
>> regardless of how it affects the size. Such oneliners must be
>> transparent to the compiler
> 
> In general I would trust the compiler to make the right
> choices here, but as I have shown it makes very little difference.

I would, but I had a couple moments when it was uninlining
almost-oneliners resulting in several Mpps network throughput
decrease =\

Thanks,
Olek