Re: [RFC PATCH v1 1/4] iio: types: add IIO_VOLUMEFLOW channel type
From: Wadim Mueller
Date: Wed May 27 2026 - 10:37:52 EST
On Tue, 26 May 2026 17:13:50 +0100
Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
> > +What:/sys/bus/iio/devices/iio:deviceX/in_volumeflow_raw
> > +What:/sys/bus/iio/devices/iio:deviceX/in_volumeflowY_raw
> > +KernelVersion:6.19
> > +Contact:linux-iio@xxxxxxxxxxxxxxx
> > +Description:
> > +Raw (unscaled) volumetric flow rate reading from the channel.
> > +To convert to standard units (litres / second) apply the
> > +channel's _scale (and _offset, when present).
>
> Formatting doesn't match rest of file at all.
Done in v2. The whitespace got lost when pasting from a wrapped
editor - v2 uses tabs and the same indent as the surrounding
blocks.
> > +What:/sys/bus/iio/devices/iio:deviceX/in_volumeflow_scale
> > +What:/sys/bus/iio/devices/iio:deviceX/in_volumeflowY_scale
> > +KernelVersion:6.19
> > +Contact:linux-iio@xxxxxxxxxxxxxxx
> > +Description:
> > +Scale factor applied to raw volumetric flow readings to obtain
> > +the value in litres per second (l/s).
> I'd just add this to the big block of existing _scale.
> The units etc are all covered in _raw so we don't need to really say more than
> this exists.
Done in v2. The separate _scale stanza is gone; the shared
_scale block at the top of the file now has one extra line:
IIO_VOLUMEFLOW litres per second
The _raw block stays for the per-channel-type description and
points at the shared _scale section for the units.
Thanks,
Wadim