Re: [PATCH net-next v06 3/6] hinic3: Add ethtool coalesce ops

[Jakub Kicinski]

On Wed, 27 May 2026 15:55:58 +0800 Fan Gong wrote:
>   Implement following ethtool callback function:
> .get_coalesce
> .set_coalesce
> 
>   These callbacks allow users to utilize ethtool for detailed
> RX coalesce configuration and monitoring.
> 
> Co-developed-by: Zhu Yikai <zhuyikai1@xxxxxxxxxxxxxx>
> Signed-off-by: Zhu Yikai <zhuyikai1@xxxxxxxxxxxxxx>
> Signed-off-by: Fan Gong <gongfan1@xxxxxxxxxx>

The NIPA CI coccicheck test is failing on the hinic3 ethtool series
(coalesce ops and/or rss ops patches).  Four new Coccinelle warnings
were introduced in drivers/net/ethernet/huawei/hinic3/hinic3_ethtool.c:

  hinic3_ethtool.c:1021:11-45: WARNING avoid newline at end of message in NL_SET_ERR_MSG_FMT_MOD
  hinic3_ethtool.c:1055:12-37: WARNING avoid newline at end of message in NL_SET_ERR_MSG_FMT_MOD
  hinic3_ethtool.c:1078:11-62: WARNING avoid newline at end of message in NL_SET_ERR_MSG_FMT_MOD
  hinic3_ethtool.c:1215:29-58: WARNING avoid newline at end of message in NL_SET_ERR_MSG_MOD

The NL_SET_ERR_MSG_MOD() and NL_SET_ERR_MSG_FMT_MOD() macros must not
be given a message string that ends with '\n'.  The netlink error-message
infrastructure handles message termination itself; a trailing newline
results in malformed extack messages visible to user space.

Please remove the trailing '\n' from all four call sites, e.g.:

  - NL_SET_ERR_MSG_FMT_MOD(extack, "some message\n");
  + NL_SET_ERR_MSG_FMT_MOD(extack, "some message");

The same rule applies to NL_SET_ERR_MSG_MOD() and the other
NL_SET_ERR_MSG* family of macros throughout the driver.