Re: [PATCH v2 01/15] KVM: TDX: Drop kvm_x86_ops.link_external_spt()

From: Edgecombe, Rick P

Date: Wed May 27 2026 - 15:58:34 EST


On Wed, 2026-05-27 at 11:27 -0700, Sean Christopherson wrote:
> > Signed-off-by: Sean Christopherson <seanjc@xxxxxxxxxx>
> > [Rick: add in trivial feedback]
> > Signed-off-by: Rick Edgecombe <rick.p.edgecombe@xxxxxxxxx>
> > Signed-off-by: Yan Zhao <yan.y.zhao@xxxxxxxxx>
> > ---
> > MMU_refactors v2:
> > - Moved this patch to the very beginning of the series so that when
> >    warnings like "KVM_BUG_ON(!is_shadow_present_pte(new_spte), kvm)" are
> >    removed from __tdp_mmu_set_spte_atomic() in TDP MMU in a later patch, the
> >    atomic zap change can be propagated via the .set_external_spte() op.
> >    (Yan).
> >
> > MMU_refactors v1:
> >   - rename external_spt->sept_pt (Rick, Yan)
>
> Put the versioning info below the "---" that delineates the diff, otherwise
> `git am` adds it to the changelog.
>
>

Hmm, it doesn't for me. The higher "---" gets picked up. Just tested on this
patch and the version logs are dropped after git am.

I use format Yan has here to keep the version logs in the commit in the git
tree. Then when sending out, it automatically gets dropped by the first applier.