Re: [PATCH 00/12] media: i2c: convert ternaries to string_choices helpers

[Laurent Pinchart]

On Wed, May 27, 2026 at 08:10:49PM +0530, Balakrishnan Sambath wrote:
> Replace boolean-to-string ternaries with helpers from
> <linux/string_choices.h> across drivers/media/i2c/.

I don't think this is an improvement.

> Strings in uppercase or mixed case ("Yes"/"No", "ON"/"OFF", "On"/"Off")
> in adv7604.c, isl7998x.c, and ths7303.c are left as-is since the
> helpers return lowercase only.
> 
> Build-tested with x86_64 allmodconfig. No functional change.
> 
> Signed-off-by: Balakrishnan Sambath <balakrishnan.s@xxxxxxxxxxxxx>
> ---
> Balakrishnan Sambath (12):
>       media: max9286: use string_choices helper
>       media: saa7110: use string_choices helper
>       media: tvp7002: use string_choices helper
>       media: vpx3220: use string_choices helper
>       media: msp3400: use string_choices helpers
>       media: tda1997x: use string_choices helper
>       media: ths8200: use string_choices helpers
>       media: adv7511: use string_choices helpers
>       media: saa7127: use string_choices helpers
>       media: adv7604: use string_choices helpers
>       media: tc358743: use string_choices helpers
>       media: adv7842: use string_choices helpers
> 
>  drivers/media/i2c/adv7511-v4l2.c   | 11 +++++-----
>  drivers/media/i2c/adv7604.c        | 26 +++++++++++-----------
>  drivers/media/i2c/adv7842.c        | 44 ++++++++++++++++++--------------------
>  drivers/media/i2c/max9286.c        |  3 ++-
>  drivers/media/i2c/msp3400-driver.c |  5 +++--
>  drivers/media/i2c/saa7110.c        |  3 ++-
>  drivers/media/i2c/saa7127.c        | 13 +++++------
>  drivers/media/i2c/tc358743.c       | 40 +++++++++++++++-------------------
>  drivers/media/i2c/tda1997x.c       |  7 +++---
>  drivers/media/i2c/ths8200.c        |  9 ++++----
>  drivers/media/i2c/tvp7002.c        |  3 ++-
>  drivers/media/i2c/vpx3220.c        |  3 ++-
>  12 files changed, 83 insertions(+), 84 deletions(-)
> ---
> base-commit: a3d78e74dd3ed04797ea351edb7f0a19b961c063
> change-id: 20260527-cleanup-string-choices-media-i2c-5abff65802ea

-- 
Regards,

Laurent Pinchart