Re: [PATCH 1/1] wifi: ath12k: support calibration-variant from device tree

[Andrew LaMarche]

Ack on the deprecation of qcom,ath12k-calibration-variant in favor of the
generic qcom,calibration-variant. 

However, drivers/net/wireless/ath/ath12k/core.c still misses the logic to 
actually load in the BDF, which this patch also accomplishes. I don’t see that
in the Qualcomm-authored series you linked. Perhaps a v2 to address this?

Andrew

> On May 27, 2026, at 3:52 PM, Jeff Johnson <jeff.johnson@xxxxxxxxxxxxxxxx> wrote:
> 
> On 5/27/2026 9:12 AM, Andrew LaMarche wrote:
>> Hi,
>> 
>> A kind ping here. I’m not sure why this functionality is missing in the first place, but it is needed for loading caldata from the device tree.
> 
> Your patch duplicates functionality in the Qualcomm authored series:
> https://msgid.link/20250228184214.337119-1-quic_rajkbhag@xxxxxxxxxxx
> 
> And note the upstream device bindings for ath10k and ath11k only support the
> generic binding qcom,calibration-variant.
> 
> There are no longer any generation-specific bindings, see:
> https://msgid.link/20250225-b-wifi-qcom-calibration-variant-v1-0-3b2aa3f89c53@xxxxxxxxxx
> 
> /jeff