Re: [RFC PATCH v5 1/2] vfs: add O_CREAT|O_DIRECTORY to open*(2)

[NeilBrown]

On Wed, 27 May 2026, Christian Brauner wrote:
> > 
> > I'm not convinced the change to EOPNOTSUPP is a good idea.  It should
> > be a separate patch so that it can be reviewed separately.
> > 
> > EOPNOTSUPP is documented as
> >        EOPNOTSUPP      Operation not supported on socket (POSIX.1-2001).
> > 
> > and we have no sockets here!
> 
> Sorry, not even userspace tooling indicates that this has anything to do
> with sockets.
> 
>     > which errno
>     /usr/bin/errno
> 
>     > errno ENOTSUP
>     ENOTSUP 95 Operation not supported
>     
>     > errno EOPNOTSUPP
>     EOPNOTSUPP 95 Operation not supported

$ man 3 errno | grep EOPNOT
     EOPNOTSUPP      Operation not supported on socket (POSIX.1-2001).
                     (ENOTSUP and EOPNOTSUPP have the same value on Linux,  but


In any case, the error code change should be in a separate patch with a
clear justification and a Cc: to linux-api@xxxxxxxxxxxxxxx.

linux-api would like to see the whole patch set I expect.

Thanks,
NeilBrown