Re: [PATCH net-next v2 06/10] net: ethernet: oa_tc6: Add MMS register formatting macro

[Andrew Lunn]

On Wed, May 27, 2026 at 12:51:51AM +0300, Ciprian Regus via B4 Relay wrote:
> From: Ciprian Regus <ciprian.regus@xxxxxxxxxx>
> 
> The Open Alliance TC6 standard defines multiple memory maps for the
> MAC-PHY's register space. These are used to separate standard, vendor
> and PHY MMD specific registers. Add a macro to make it more clear which
> memory map each register is part of and allow easier definition.
> 
> Signed-off-by: Ciprian Regus <ciprian.regus@xxxxxxxxxx>
> 
> ---
> v2 changelog:
>  - New patch
> ---
>  drivers/net/ethernet/oa_tc6.c | 4 ++--
>  include/linux/oa_tc6.h        | 3 +++
>  2 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/oa_tc6.c b/drivers/net/ethernet/oa_tc6.c
> index 904bd790159d..876891ca9859 100644
> --- a/drivers/net/ethernet/oa_tc6.c
> +++ b/drivers/net/ethernet/oa_tc6.c
> @@ -471,7 +471,7 @@ int oa_tc6_mdiobus_read_c45(struct mii_bus *bus, int addr, int devnum,
>  	if (ret < 0)
>  		return ret;
>  
> -	ret = oa_tc6_read_register(tc6, (ret << 16) | regnum, &regval);
> +	ret = oa_tc6_read_register(tc6, OA_TC6_MMS_REG(ret, regnum), &regval);

How about:

	ret = oa_tc6_read_register_mms(tc6, ret, regnum, &regval);

and let oa_tc6_read_register_mms() combine them in the correct way.

Maybe also change

	ret = oa_tc6_get_phy_c45_mms(devnum);

to

	mms = oa_tc6_get_phy_c45_mms(devnum);

	Andrew