[PATCH v4 0/7] clk: qcom: Add common clkref support and migrate Glymur and Mahua

From: Qiang Yu

Date: Wed May 27 2026 - 22:33:44 EST


This series adds a common clkref_en implementation and converts glymur
and mahua to use it, along with the related binding and DTS updates.

The PCIe clkref clocks on Glymur and Mahua gate the QREF block which
provides reference clocks to the PCIe PHYs. QREF requires LDO supplies
and a reference voltage from the refgen block to operate. The refgen
block itself requires vdda-refgen_0p9 and vdda-refgen_1p2 LDOs to
function.

Previously, these QREF votes were done in PHY drivers. In earlier
discussion [1], the feedback was that this is the wrong ownership point:
those supplies are for the QREF controlled by clkref registers, not for
the PHY directly. Based on that feedback, this series keeps the
regulator handling with the clkref control path.

Another reason for this series is reuse. clkref_en registers may live in
different blocks across platforms (for example TCSR on Glymur, TLMM on
SM8750 [2]), while the behavior is the same. The common helper lets each
driver provide simple descriptors (name, offset, optional supplies) and
reuse shared registration and runtime logic.

Glymur and Mahua share the same QREF TX/RPT/RX component naming but
have different PCIe QREF topologies. Both are handled in tcsrcc-glymur.c
via match_data to select the correct descriptor table per compatible.

[1] https://lore.kernel.org/lkml/aEBfV2M-ZqDF7aRz@xxxxxxxxxxxxxxxxxxxx/
[2] https://lore.kernel.org/linux-arm-msm/20260202-topic-8750_tcsr-v1-0-cd7e6648c64f@xxxxxxxxxxxxxxxx/

Changes in v4:
- Add mahua QREF support (binding, driver, DTS) to avoid dtb check error
- Override pcie5_phy ref clock to RPMH_CXO_CLK on mahua since
TCSR_PCIE_1_CLKREF_EN is not available
- Rename regulator arrays to topology-based names and merge duplicates
- Remove else: false blocks from binding
- Sort supply properties alphabetically in binding and DTS
- Link to v3: https://lore.kernel.org/all/20260506-qref_vote_0506-v3-0-5ab71d2e6f16@xxxxxxxxxxxxxxxx/

Changes in v3:
- Fix dtb check error: allOf:0: 'then' is a dependency of 'if'.
- Link to v2: https://lore.kernel.org/all/20260420-vote_qref_in_tcsrcc-v2-0-589a23ae640a@xxxxxxxxxxxxxxxx/

Changes in v2:
- RFC tag dropped
- Changed back to additionalProperties: false
- Moved all Glymur supply properties into top-level properties so they are explicitly defined.
- Link to v1: https://lore.kernel.org/all/20260331-qref_vote-v1-0-3fd7fbf87864@xxxxxxxxxxxxxxxx/

Signed-off-by: Qiang Yu <qiang.yu@xxxxxxxxxxxxxxxx>
---
Qiang Yu (7):
dt-bindings: clock: qcom,sm8550-tcsr: Add QREF/REFGEN supply properties for glymur and mahua
clk: qcom: Add generic clkref_en support
clk: qcom: tcsrcc-glymur: Migrate tcsr_pcie_N_clkref_en to clk_ref common helper
clk: qcom: tcsrcc-glymur: Add Mahua QREF regulator support
arm64: dts: qcom: glymur: Add QREF regulator supplies to TCSR
arm64: dts: qcom: mahua: Add QREF regulator supplies to TCSR
arm64: dts: qcom: mahua: Switch pcie5_phy ref clock to RPMH_CXO_CLK

.../bindings/clock/qcom,sm8550-tcsr.yaml | 66 ++++
arch/arm64/boot/dts/qcom/glymur-crd.dts | 20 +
arch/arm64/boot/dts/qcom/mahua-crd.dts | 15 +
arch/arm64/boot/dts/qcom/mahua.dtsi | 13 +
drivers/clk/qcom/Makefile | 1 +
drivers/clk/qcom/clk-ref.c | 205 +++++++++++
drivers/clk/qcom/tcsrcc-glymur.c | 407 +++++++++------------
include/linux/clk/qcom.h | 69 ++++
8 files changed, 557 insertions(+), 239 deletions(-)
---
base-commit: e7e28506af98ce4e1059e5ec59334b335c00a246
change-id: 20260527-tcsr_qref_0527-f83ea225903d

Best regards,
--
Qiang Yu <qiang.yu@xxxxxxxxxxxxxxxx>