[PATCH 3/4] rtc: sc27xx: convert to dev_err_probe()
From: Balakrishnan Sambath
Date: Wed May 27 2026 - 23:47:20 EST
Use dev_err_probe() in place of dev_err() and return, which
communicates the error type and helps debugging hardware issues.
No functional change.
Signed-off-by: Balakrishnan Sambath <balakrishnan.s@xxxxxxxxxxxxx>
---
drivers/rtc/rtc-sc27xx.c | 24 ++++++++----------------
1 file changed, 8 insertions(+), 16 deletions(-)
diff --git a/drivers/rtc/rtc-sc27xx.c b/drivers/rtc/rtc-sc27xx.c
index 2b83561d4d2..2c6d4565389 100644
--- a/drivers/rtc/rtc-sc27xx.c
+++ b/drivers/rtc/rtc-sc27xx.c
@@ -574,10 +574,8 @@ static int sprd_rtc_probe(struct platform_device *pdev)
return -ENODEV;
ret = of_property_read_u32(node, "reg", &rtc->base);
- if (ret) {
- dev_err(&pdev->dev, "failed to get RTC base address\n");
- return ret;
- }
+ if (ret)
+ return dev_err_probe(&pdev->dev, ret, "failed to get RTC base address\n");
rtc->irq = platform_get_irq(pdev, 0);
if (rtc->irq < 0)
@@ -592,26 +590,20 @@ static int sprd_rtc_probe(struct platform_device *pdev)
/* check if we need set the alarm interrupt */
ret = sprd_rtc_check_alarm_int(rtc);
- if (ret) {
- dev_err(&pdev->dev, "failed to check RTC alarm interrupt\n");
- return ret;
- }
+ if (ret)
+ return dev_err_probe(&pdev->dev, ret, "failed to check RTC alarm interrupt\n");
/* check if RTC time values are valid */
ret = sprd_rtc_check_power_down(rtc);
- if (ret) {
- dev_err(&pdev->dev, "failed to check RTC time values\n");
- return ret;
- }
+ if (ret)
+ return dev_err_probe(&pdev->dev, ret, "failed to check RTC time values\n");
ret = devm_request_threaded_irq(&pdev->dev, rtc->irq, NULL,
sprd_rtc_handler,
IRQF_ONESHOT | IRQF_EARLY_RESUME,
pdev->name, rtc);
- if (ret < 0) {
- dev_err(&pdev->dev, "failed to request RTC irq\n");
- return ret;
- }
+ if (ret < 0)
+ return dev_err_probe(&pdev->dev, ret, "failed to request RTC irq\n");
device_init_wakeup(&pdev->dev, true);
--
2.34.1