Re: [PATCH v3 0/8] mm: speed up ZONE_DEVICE memmap initialization

From: Li Zhe

Date: Thu May 28 2026 - 03:06:55 EST


On Wed, 27 May 2026 13:46:37 -0700, akpm@xxxxxxxxxxxxxxxxxxxx wrote:

> AI review had a number of things to say:
> https://sashiko.dev/#/patchset/20260527033636.28231-1-lizhe.67@xxxxxxxxxxxxx

Thanks for the review. All four points are valid.

1. The head-page template setup should not run page initialization and
refcount helpers on a stack-resident struct page.
2. The compound-tail template path has the same issue and should avoid
running compound-tail/refcount setup on a stack object.
3. The x86 memcpy_streaming() eligibility check is too permissive, so some
transfers that cannot stay entirely on the non-temporal path may still
go through memcpy_flushcache().
4. memcpy_flushcache_small() should reject unsupported sizes before issuing
any store, otherwise fallback can observe partial writes.

I have prepared corresponding fixups on top of v3.

Thanks,
Zhe