回复: 回复: [PATCH v2 1/3] dt-bindings: i2c: Add StarFive JHB100 I2C

[Lianfeng Ouyang]

> -----邮件原件-----
> 发件人: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> 发送时间: 2026年5月28日 15:48
> 收件人: Lianfeng Ouyang <lianfeng.ouyang@xxxxxxxxxxxxxxxx>; Andi Shyti
> <andi.shyti@xxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzk+dt@xxxxxxxxxx>; Conor Dooley <conor+dt@xxxxxxxxxx>; Mika
> Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>; Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx>
> 抄送: linux-i2c@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx
> 主题: Re: 回复: [PATCH v2 1/3] dt-bindings: i2c: Add StarFive JHB100 I2C
> 
> On 28/05/2026 08:57, Lianfeng Ouyang wrote:
> >>> +    default: 400000
> >>> +
> >>> +  i2c-sda-hold-time-ns:
> >>
> >> So you added a generic property - where is it documented? Generic
> >> properties must be in common schema or dtschema.
> >>
> >> And please prove that none of the generic properties are suitable.
> >>
> >>> +    $ref: /schemas/types.yaml#/definitions/uint32
> >>
> >> I don't think you tested it. And this concludes my review. I finished
> >> here. Please do not send untested bindings.
> >>
> >>
> >> Best regards,
> >> Krzysztof
> >
> > Sorry, I didn't know I needed to run dt-binding_check before, but now I have
> 
> Every doc asks that. DTS101 slides or my earlier talks as well... Other
> people talks as well... and you received that request last time at v1.
> Please do not repeat the same mistakes because then we feel like our
> feedback is wasted.
> 
> Best regards,
> Krzysztof

I'm very sorry, I know that language is not strong at this moment. In order to 
prevent your feedback from being wasted, I will correct the relevant errors 
and run tests in the next version. Thank you

Best Regards,
Lianfeng Ouyang