Re: [PATCH] spi: spi-mem: avoid mutating op template in spi_mem_supports_op()
From: Miquel Raynal
Date: Thu May 28 2026 - 05:31:24 EST
> spi_mem_supports_op() accepts a const struct spi_mem_op pointer but
> casts away const internally to call spi_mem_adjust_op_freq(). This
> mutates the caller's op template, which causes stale max_freq values
> when callers reuse persistent templates - subsequent calls won't
> re-apply the device frequency cap since spi_mem_adjust_op_freq()
> skips non-zero values.
>
> Fix by operating on a stack-local copy instead.
>
> Fixes: a4f8e70d75dd ("spi: spi-mem: add spi_mem_adjust_op_freq() in spi_mem_supports_op()")
> Cc: Tianyu Xu <xtydtc@xxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Santhosh Kumar K <s-k6@xxxxxx>
> ---
Reviewed-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>