RE: [PATCH v4 4/8] arm64: dts: renesas: r9a09g047: Add RZ/G3E Sound support
From: John Madieu
Date: Thu May 28 2026 - 06:10:52 EST
Hi Geert,
Thanks for your review.
> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: Mittwoch, 27. Mai 2026 16:23
> To: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> Subject: Re: [PATCH v4 4/8] arm64: dts: renesas: r9a09g047: Add RZ/G3E
> Sound support
>
> Hi John,
>
> On Mon, 25 May 2026 at 13:07, John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> wrote:
> > Add the snd_rzg3e node for the RZ/G3E SoC with all sub-components:
> >
> > - SSI (Serial Sound Interface) units 0-9
> > - SSIU (Serial Sound Interface Unit) units 0-27
> > - SRC (Sample Rate Converter) units 0-9
> > - CTU (Channel Transfer Unit) units 0-7
> > - DVC (Digital Volume Control) units 0-1
> > - MIX (Mixer) units 0-1
> >
> > Sub-node names follow the new RZ/G3E sound binding: unprefixed 'ssi',
> > 'ssiu', 'src', 'dvc', 'mix', 'ctu' wrapper nodes instead of the legacy
> > 'rcar_sound,xxx' R-Car prefix.
> >
> > Wire up all 5 DMA controllers (dmac0-dmac4) for each audio sub-node
> > with repeated channel names, so that the DMA core can pick the first
> > available controller.
> >
> > Signed-off-by: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> > ---
> >
> > Changes:
> >
> > v4:
> > - Rename the indexed clock-names and reset-names from the dotted
> > form (ssi.N, src.N, adg.ssi.N, clk_a, clk_b, clk_c, clk_i) to the
> > hyphenated form (ssi-N, src-N, adg-ssi-N, audio-clka, audio-clkb,
> > audio-clkc, audio-clki), matching the new RZ/G3E sound binding.
> > - Rename the sub-nodes from the legacy rcar_sound,{ctu,dvc,mix,src,
> > ssi,ssiu} prefix to the unprefixed ctu/dvc/mix/src/ssi/ssiu names
> > used by the new RZ/G3E sound binding.
> > - Reorder the clocks and resets phandle lists into ascending index
> > order and annotate each entry with a per-line comment naming the
> > clock / reset.
> > - Drop the #sound-dai-cells and #clock-cells explanatory comment
> > blocks from the node.
> > - Align the continuation lines of the dmas property.
> > - Fix the commit message: the node label is snd_rzg3e (v3 referred
> > to it as rzg3e_sound), and add a paragraph noting the unprefixed
> > sub-node names.
>
> Thanks for the update!
>
> > --- a/arch/arm64/boot/dts/renesas/r9a09g047.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r9a09g047.dtsi
> > @@ -912,6 +912,482 @@ rsci9: serial@12803000 {
> > status = "disabled";
> > };
> >
> > + snd_rzg3e: sound@13c00000 {
> > + compatible = "renesas,r9a09g047-sound";
> > + reg = <0 0x13c00000 0 0x10000>, /* SCU */
> > + <0 0x13c20000 0 0x10000>, /* ADG */
> > + <0 0x13c30000 0 0x1000>, /* SSIU */
> > + <0 0x13c31000 0 0x1F000>, /* SSI */
> > + <0 0x13c50000 0 0x10000>; /* Audio DMAC
> peri peri */
> > + reg-names = "scu", "adg", "ssiu", "ssi",
> "audmapp";
> > + clocks = <&cpg CPG_MOD 245>, /* ssi-all */
> > + <&cpg CPG_MOD 385>, /* ssi-0 */
> > + <&cpg CPG_MOD 386>, /* ssi-1 */
> > + <&cpg CPG_MOD 387>, /* ssi-2 */
> > + <&cpg CPG_MOD 388>, /* ssi-3 */
> > + <&cpg CPG_MOD 389>, /* ssi-4 */
> > + <&cpg CPG_MOD 390>, /* ssi-5 */
> > + <&cpg CPG_MOD 391>, /* ssi-6 */
> > + <&cpg CPG_MOD 392>, /* ssi-7 */
> > + <&cpg CPG_MOD 393>, /* ssi-8 */
> > + <&cpg CPG_MOD 394>, /* ssi-9 */
> > + <&cpg CPG_MOD 372>, /* src-0 */
> > + <&cpg CPG_MOD 373>, /* src-1 */
> > + <&cpg CPG_MOD 374>, /* src-2 */
> > + <&cpg CPG_MOD 375>, /* src-3 */
> > + <&cpg CPG_MOD 376>, /* src-4 */
> > + <&cpg CPG_MOD 377>, /* src-5 */
> > + <&cpg CPG_MOD 378>, /* src-6 */
> > + <&cpg CPG_MOD 379>, /* src-7 */
> > + <&cpg CPG_MOD 380>, /* src-8 */
> > + <&cpg CPG_MOD 381>, /* src-9 */
> > + <&cpg CPG_MOD 370>, /* mix-0 */
> > + <&cpg CPG_MOD 371>, /* mix-1 */
> > + <&cpg CPG_MOD 370>, /* ctu-0 */
> > + <&cpg CPG_MOD 371>, /* ctu-1 */
> > + <&cpg CPG_MOD 368>, /* dvc-0 */
> > + <&cpg CPG_MOD 369>, /* dvc-1 */
> > + <&cpg CPG_MOD 251>, /* audio-clka */
> > + <&cpg CPG_MOD 252>, /* audio-clkb */
> > + <&cpg CPG_MOD 253>, /* audio-clkc */
> > + <&cpg CPG_MOD 250>, /* audio-clki */
> > + <&cpg CPG_MOD 384>, /* ssif_supply
> */
> > + <&cpg CPG_MOD 246>, /* scu */
> > + <&cpg CPG_MOD 247>, /* scu_x2 */
> > + <&cpg CPG_MOD 382>, /* scu_supply */
> > + <&cpg CPG_MOD 352>, /* adg-ssi-0 */
> > + <&cpg CPG_MOD 353>, /* adg-ssi-1 */
> > + <&cpg CPG_MOD 354>, /* adg-ssi-2 */
> > + <&cpg CPG_MOD 355>, /* adg-ssi-3 */
> > + <&cpg CPG_MOD 356>, /* adg-ssi-4 */
> > + <&cpg CPG_MOD 357>, /* adg-ssi-5 */
> > + <&cpg CPG_MOD 358>, /* adg-ssi-6 */
> > + <&cpg CPG_MOD 359>, /* adg-ssi-7 */
> > + <&cpg CPG_MOD 360>, /* adg-ssi-8 */
> > + <&cpg CPG_MOD 361>, /* adg-ssi-9 */
> > + <&cpg CPG_MOD 248>, /* audmapp */
> > + <&cpg CPG_MOD 249>; /* adg */
>
> Please drop these comments...
Will do in next version.
Regards,
John.